Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#2230 closed defect (fixed)

_ComputeRepositoryURL is broken with respect to multi-repo changes.

Reported by: tom.prince Owned by: tom.prince
Priority: major Milestone: 0.8.7
Version: master Keywords:
Cc:

Description

_ComputeRepositoryURL needs the codebase passed in from the source step. The easiest way to get this is to pass in the codebase in the constructor.

Since this involves moving the constructor upcall, fixing this creates a merge conflict with the [step-factor changes](https://github.com/tomprince/buildbot/compare/buildbot:master...magic-__new).

I will fix this, once that branch is merged.

Change History (3)

comment:1 Changed 7 years ago by dustin

magic-__new__ is merged now

comment:2 Changed 7 years ago by Tom Prince

  • Resolution set to fixed
  • Status changed from new to closed

Fix _ComputeRepositoryURL for multirepo support.

Fixes #2241, #2230.

Changeset: 0464a04c48887d03d830ee4579dcaba5eb918734

comment:3 Changed 7 years ago by Tom Prince

Fix _ComputeRepositoryURL for multirepo support.

Fixes #2241, #2230.

Changeset: 0464a04c48887d03d830ee4579dcaba5eb918734

Note: See TracTickets for help on using tickets.