Opened 8 years ago

Closed 8 years ago

#2209 closed enhancement (fixed)

GerritStatusPush should be able to ignore build results

Reported by: sanxiyn Owned by:
Priority: minor Milestone: 0.8.6
Version: 0.8.5 Keywords: gerrit
Cc:

Description

There should be a way to ignore build results (notably RETRY). Currently a review is always sent no matter what reviewCB does, for Gerrit+Git.

Attached patch lets Gerrit+Git to ignore build results if reviewCB returns None message like Gerrit+Repo does, and documents this fact.

Attachments (1)

no_review.txt (2.6 KB) - added by sanxiyn 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by sanxiyn

comment:1 Changed 8 years ago by tom.prince

  • Milestone changed from undecided to 0.8.6
  • Priority changed from major to minor

This patch looks good. Should the default callback also ignore retry errors? Also, I'd like to properly attribute this patch (easiest way would be to simply submit a pullrequest on github.

comment:2 Changed 8 years ago by sanxiyn

I changed the default callback to ignore RETRY and sent a pull request. http://trac.buildbot.net/ticket/2209

Version 0, edited 8 years ago by sanxiyn (next)

comment:3 Changed 8 years ago by Tom Prince

  • Resolution set to fixed
  • Status changed from new to closed

Merge pull request #325 from sanxiyn/master

GerritStatusPush? should be able to ignore build results

Fixes #2209.

Changeset: 2532e97aab1652787696b1718320d8ce92ba1a4c

Note: See TracTickets for help on using tickets.