Opened 6 years ago

Last modified 4 years ago

#2207 new defect

MailNotifier use the user-db by default, but that doesn't properly get populated.

Reported by: tom.prince Owned by:
Priority: critical Milestone: 0.9.+
Version: master Keywords: users, mail


By default, MailNotifier? looks up users in the database, based on the uid stored with the relevant changes. It then tries to get the email associated to that id. However, the various change sources don't populate the email attribute of users they create, so most users won't have an associated email record (even if their identifier is an email address).

This can be worked around by passing lookup="" which avoids using the database.

Change History (8)

comment:1 Changed 6 years ago by dustin

What's the path to fixing this in 0.8.6?

If that requires major work on the users support, I'd rather find a workaround for 0.8.6, or just leave it unfixed there (since this was the case in 0.8.5 as well).

comment:2 Changed 6 years ago by tom.prince

The simple workaround is to not default to useUsers, since it is essentially broken with current state of the users code.

comment:3 Changed 6 years ago by dustin

Looking back at v0.8.4, in that version if lookup wasn't set, nothing was sent. From what I can tell, in master, if lookup isn't set, then MailNotifier will attempt to use the database, which most likely will not result in any email addresses, so no mail will be sent. In the rare case that the user support is actually set up, it *will* send email, though.

So it sounds like this is no less functional than 0.8.4, and possibly more functional.

Have I missed something?

comment:4 Changed 6 years ago by Dustin J. Mitchell

Document that user objects don't help MailNotifier? .. yet

This is actually the case in all previous versions of MailNotifier?, although the documentation has been misleading/wrong since forever. Refs #2207.

Changeset: 915bb5b1724b83e17e9f59c58a0477b6e33633f6

comment:5 Changed 6 years ago by dustin

  • Milestone changed from 0.8.6 to 0.8.+

To be fixed in a Future Version, then.

comment:6 Changed 6 years ago by dustin

  • Keywords users added

comment:7 Changed 6 years ago by dustin

  • Keywords mail added

comment:8 Changed 4 years ago by dustin

  • Milestone changed from 0.8.+ to 0.9.+

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.