Ticket #22 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

reconfig on master removes ability to stop running builds

Reported by: rhelmer Owned by: warner
Priority: major Milestone: 0.7.7
Version: 0.7.5 Keywords:
Cc: bhearsum@…

Description

After doing a "buildbot reconfig ." on the master, the "Stop build" button is no longer available for a running build.

Change History

comment:1 Changed 5 years ago by warner

code notes: this is because the running build is attached to the old Builder, and the new Builder (which is the one that gets asked when that web page is created) doesn't know about it.

This should only happen when the reconfig modifies the Builder in question: if it doesn't touch that Builder, the Stop Build button should still be available.

To fix this, we should change the Builder to maybe grab weakrefs to the running builds of its predecessor, so that IBuilderControl.getBuild() is able to give access to those builds.

comment:2 Changed 4 years ago by warner

  • Version set to 0.7.5
  • Milestone set to 0.7.7

comment:3 Changed 4 years ago by bhearsum

  • Cc bhearsum@… added

comment:4 Changed 4 years ago by warner

  • Status changed from new to closed
  • Resolution set to fixed

fixed, in [6eadcbd75c197cd8f805ad98d0ba86d567258217].

Note: See TracTickets for help on using tickets.