reconfig doesn't adopt new slaves

[dustin]

When adding a slave in

 https://github.com/buildbot/metabbotcfg/pull/1/files

a reconfig (or two) didn't do the trick. The slave appeared in the web UI, but twistd.log showed

2012-02-10 00:50:49+0100 [Broker,498,69.165.170.253] invalid login from user 'tomprince-hermes-gentoo-1'
2012-02-10 00:50:49+0100 [Broker,498,69.165.170.253] Peer will receive following PB traceback:
2012-02-10 00:50:49+0100 [Broker,498,69.165.170.253] Unhandled Error
        Traceback (most recent call last):
        Failure: twisted.cred.error.UnauthorizedLogin:

A restart fixed it.

[dustin]

Hmm, I can't reproduce locally:

2012-02-21 17:57:33-0500 [-] beginning configuration update
2012-02-21 17:57:33-0500 [-] Loading configuration from '/Users/dustin/code/buildbot/t/buildbot/sand27/master/master.cfg'
2012-02-21 17:57:33-0500 [-] [<BuildSlave 'blahslave'>]
2012-02-21 17:57:33-0500 [-] slaves [<BuildSlave 'blahslave'>]
2012-02-21 17:57:33-0500 [-] (TCP Port 8010 Closed)
2012-02-21 17:57:33-0500 [-] Stopping factory <buildbot.status.web.baseweb.RotateLogSite instance at 0x102f11dd0>
2012-02-21 17:57:33-0500 [-] RotateLogSite starting on 8010
2012-02-21 17:57:33-0500 [-] Starting factory <buildbot.status.web.baseweb.RotateLogSite instance at 0x102f16050>
2012-02-21 17:57:33-0500 [-] Setting up http.log rotating 10 files of 10000000 bytes each
2012-02-21 17:57:33-0500 [-] WebStatus using (/Users/dustin/code/buildbot/t/buildbot/sand27/master/public_html)
2012-02-21 17:57:33-0500 [-] configuration update complete
2012-02-21 17:57:53-0500 [-] beginning configuration update
2012-02-21 17:57:53-0500 [-] Loading configuration from '/Users/dustin/code/buildbot/t/buildbot/sand27/master/master.cfg'
2012-02-21 17:57:53-0500 [-] [<BuildSlave 'blahslave'>, <BuildSlave 'example-slave'>]
2012-02-21 17:57:53-0500 [-] slaves [<BuildSlave 'blahslave'>, <BuildSlave 'example-slave'>]
2012-02-21 17:57:53-0500 [-] adding 1 new slaves, removing 0
2012-02-21 17:57:53-0500 [-] (TCP Port 8010 Closed)
2012-02-21 17:57:53-0500 [-] Stopping factory <buildbot.status.web.baseweb.RotateLogSite instance at 0x102f16050>
2012-02-21 17:57:53-0500 [-] RotateLogSite starting on 8010
2012-02-21 17:57:53-0500 [-] Starting factory <buildbot.status.web.baseweb.RotateLogSite instance at 0x102f39248>
2012-02-21 17:57:53-0500 [-] Setting up http.log rotating 10 files of 10000000 bytes each
2012-02-21 17:57:53-0500 [-] WebStatus using (/Users/dustin/code/buildbot/t/buildbot/sand27/master/public_html)
2012-02-21 17:57:53-0500 [-] configuration update complete
2012-02-21 17:58:16-0500 [Broker,0,127.0.0.1] slave 'example-slave' attaching from IPv4Address(TCP, '127.0.0.1', 56171)
2012-02-21 17:58:16-0500 [Broker,0,127.0.0.1] Starting buildslave keepalive timer for 'example-slave'
2012-02-21 17:58:16-0500 [Broker,0,127.0.0.1] Got slaveinfo from 'example-slave'
2012-02-21 17:58:16-0500 [Broker,0,127.0.0.1] bot attached

I suspect I missed something in this process, as I was working on merging the reconfig.