MailNotifier fails to send message

[kevbroch]

2012-02-03 16:10:16-0800 [-] Exception caught notifying <buildbot.status.mail.MailNotifier? instance at 0x104fe0b48> of buildFinished event 2012-02-03 16:10:16-0800 [-] Unhandled Error

Traceback (most recent call last):

File "/Library/Frameworks/Python?.framework/Versions/2.7/lib/python2.7/site-packages/buildbot-0.8.5_384_gc76684e-py2.7.egg/buildbot/status/build.py",

line 285, in buildFinished

w.callback(self)

File "/Library/Frameworks/Python?.framework/Versions/2.7/lib/python2.7/site-packages/Twisted-11.1.0-py2.7-macosx-10.6-intel.egg/twisted/internet/defe

r.py", line 362, in callback

self._startRunCallbacks(result)

File "/Library/Frameworks/Python?.framework/Versions/2.7/lib/python2.7/site-packages/Twisted-11.1.0-py2.7-macosx-10.6-intel.egg/twisted/internet/defe

r.py", line 458, in _startRunCallbacks

self._runCallbacks()

File "/Library/Frameworks/Python?.framework/Versions/2.7/lib/python2.7/site-packages/Twisted-11.1.0-py2.7-macosx-10.6-intel.egg/twisted/internet/defe

r.py", line 545, in _runCallbacks

current.result = callback(current.result, *args, kw)

--- <exception caught here> ---

File "/Library/Frameworks/Python?.framework/Versions/2.7/lib/python2.7/site-packages/buildbot-0.8.5_384_gc76684e-py2.7.egg/buildbot/status/builder.py

", line 512, in _buildFinished

w.buildFinished(name, s, results)

File "/Library/Frameworks/Python?.framework/Versions/2.7/lib/python2.7/site-packages/buildbot-0.8.5_384_gc76684e-py2.7.egg/buildbot/status/mail.py",

line 430, in buildFinished

return self.buildMessage(name, [build], results)

File "/Library/Frameworks/Python?.framework/Versions/2.7/lib/python2.7/site-packages/buildbot-0.8.5_384_gc76684e-py2.7.egg/buildbot/status/mail.py", line 649, in buildMessage

d = self.useUsers(build)

File "/Library/Frameworks/Python?.framework/Versions/2.7/lib/python2.7/site-packages/buildbot-0.8.5_384_gc76684e-py2.7.egg/buildbot/status/mail.py", line 668, in useUsers

d = self.parent.db.changes.getChangeUids(change.number)

exceptions.AttributeError?: 'NoneType?' object has no attribute 'changes'

[tom.prince]

Did you happen to reconfigure about the time this occured?

It looks like self.parent is None here, so my guess as to what happend is

1. MailNotifier? was triggered
2. MailNotifier? blocks
3. master is reconfigured, removing MailNotifier? from master
4. MailNotifier? resumes, with self.parent = None
5. This error is triggered.

[kevbroch]

Just tried it again and didn't touch anything while the build was going.

I only get this failure when I cfg MailNotifier? for: mode='failing',

[tom.prince]

Can you attach the twistd.log?

[kevbroch]

I tracked this down to problem with my configuration. I have a project that builds from multiple svn repos and so I trigger my builds and define a change filter on those. Upon removing all but one of those change sources, I no longer get this exception. I imagine this is a problem with the way in which I am configuring things but have not yet figured out the proper way to go about it.

Thanks for you help with debugging this.

[tom.prince]

Can you post your config and twistd.log (here or on #twisted on freenode). If misconfiguration is triggering this, it would be better to detect it and error out, rather than throwing random exceptions.

[kevbroch]

Sorry, I am unable to post config or twistd.log for my project. I've tried to duplicate the problem using other code but was unable.

I have figured out my configuration problem which was that I was naming the 3 separate cchange source?s with the same name. I was then creating a ChangeFilter? with that same single name.

Now I am not explicitly given the change sources names nor am I using the change filter.

[dustin]

Sounds fixed, then? Or at least, we don't have the right clues to figure out what's up. The guess in comment 1 sounds about right, and I wonder if this is some problem with lingering mailnotifiers..