Ticket #2186 (closed enhancement: fixed)
github change_hook needs security by default
|Reported by:||stefanha||Owned by:|
|Version:||0.8.5||Keywords:||github web sprint|
Description (last modified by dustin) (diff)
The buildbot documentation does not explain the security implications of enabling this change_hook. From what I can tell there are no checks in place to ensure the HTTP request is really from Github.
Anyone who pokes this URL will be able to trigger builds. It's also not clear to me whether builds are restricted to just the git repositories configured on the buildmaster or whether the repo URL from the HTTP request will be used.
Please document the security implications of the github change_hook.
I suggest supporting a secret token that can be configured both on the buildmaster and github side. If the HTTP request does not include the secret token then it will be denied. One way of doing this would be to customize the github change_hook URI, e.g. http://server/change_hook/1e505aa83c25910, so that it is not guessable.
- Keywords github web sprint added; github,web removed
- Priority changed from major to critical
- Milestone changed from undecided to 0.8.7