Ticket #2160 (closed defect: fixed)

Opened 19 months ago

Last modified 4 months ago

Interlock documentation refers to "shared" lock mode, should be "exclusive"

Reported by: ggolan Owned by:
Priority: patches-accepted Milestone: undecided
Version: 0.8.5 Keywords: docs
Cc:

Description

There is a small documentation mistake referring to a "shared" mode for lock access. It would appear that it should just say "exclusive" instead.

Page

http://buildbot.net/buildbot/docs/current/manual/cfg-interlocks.html

Offending Paragraph in Examples

To use locks, you add them with a locks argument to a build or a step. Each use of a lock is either in counting mode (that is, possibly shared with other builds) or in exclusive mode, and this is indicated with the syntax lock.access(mode), where mode is one of "counting" or "shared".

Change History

comment:1 Changed 19 months ago by ggolan

  • Keywords docs added; documentation removed

comment:2 Changed 19 months ago by dustin

  • Status changed from new to closed
  • Resolution set to duplicate

This was fixed already, and is visible in the "latest" docs on buildbot.net.

commit ee7d36d5609d19b3f9372e134306572055e9f9c4
Author: William Deegan <bill@baddogconsulting.com>
Date:   Tue Sep 20 14:13:29 2011 -0700

    fixed lock mode description, should be counting or exclusive and not counting or shared

diff --git a/master/docs/manual/cfg-interlocks.rst b/master/docs/manual/cfg-interlocks.rst
index f1399f8..3265979 100644
--- a/master/docs/manual/cfg-interlocks.rst
+++ b/master/docs/manual/cfg-interlocks.rst
@@ -87,7 +87,7 @@ locks at other times.
 To use locks, you add them with a ``locks`` argument to a build or a step.
 Each use of a lock is either in counting mode (that is, possibly shared with
 other builds) or in exclusive mode, and this is indicated with the syntax
-``lock.access(mode)``, where :data:`mode` is one of ``"counting"`` or ``"shared"``.
+``lock.access(mode)``, where :data:`mode` is one of ``"counting"`` or ``"exclusive"``.
 
 A build or build step proceeds only when it has acquired all locks. If a build
 or step needs a lot of locks, it may be starved [#]_ by other builds that need

comment:3 Changed 5 months ago by Tom Prince

  • Resolution changed from duplicate to fixed

Don't require pycrpyto for telnet manhole.

Fixes #2160.

Changeset: eb1d34bd7d5fcffc50851bacd635f19d95968e74

comment:4 Changed 4 months ago by Tom Prince

Don't require pycrpyto for telnet manhole.

Fixes #2160.

Changeset: eb1d34bd7d5fcffc50851bacd635f19d95968e74

Note: See TracTickets for help on using tickets.