Ticket #2144 (closed defect: fixed)

Opened 19 months ago

Last modified 18 months ago

sample.cfg needlessly depends on mail.smtp

Reported by: tom.prince Owned by:
Priority: major Milestone: undecided
Version: 0.8.5 Keywords:
Cc:

Description

This seems to be due to the fact that buildbot.buildslave imports buildbot.status.mail to automatically send mail on missing slaves.

Change History

comment:1 Changed 19 months ago by tom.prince

  • Type changed from undecided to defect

That is, twisted.mail.smtp (i.e. twisted-mail)

But, this isn't a dependency.

comment:2 Changed 18 months ago by Dustin J. Mitchell

  • Status changed from new to closed
  • Resolution set to fixed

Do not fail if twisted.mail can't be imported

This allows other parts of Buildbot (e.g., buildbot.buildslave) to import mail.py, even if only some parts of Twisted are installed. Fixes #2144.

Changeset: de491bcc39eba823da377d57378906933b10674f

Note: See TracTickets for help on using tickets.