SVN post commit script successfully submits change to PBChangeSource but reports Unpersistable data: instance of class buildbot.changes.changes.Change deemed insecure

[ggolan]

During a migration from 0.8.3 to 0.8.5 the svn_buildbot.py script began to emit a message not previously seen reporting that there was unpresistable data in the form of an instance of the class buildbot.changes.changes.Change which is deemed insecure. Though the change is correctly submitted to the buildmaster and everything flows correctly after that, some understanding of the severity of this message would be useful.

The script has been modified from the one found in the contrib directory but a double check of the diff between the 0.8.5 script and the one in use does not show any obvious cause. The only major difference is that my version of the script populates the category field in the change. I have included a pprint of the change object.

The command and return value:

bash# ./svn_buildbot.py -s buildbot -p 9989 -r "/var/www/svn/" -v "12345"
Repo: /var/www/svn/
quitting! because ([(True, Unpersistable('Unpersistable data: instance of class buildbot.changes.changes.Change deemed insecure'))], 'SUCCESS')

The changes object before it is returned by getChanges in the ChangeSender class:

[{'branch': u'branches/brname',
  'category': u'branches',
  'comments': u'this is a comment',
  'files': [u'somedir/file1.c', u'somedir/file2.c'],
  'project': u'projname',
  'repository': u'/var/www/svn/',
  'revision': '12345',
  'src': 'svn',
  'who': u'myusername'}]

[Dustin J. Mitchell]

Don't return Change objects from perspective_addChange

Change objects aren't safely jellyable, so they cannot be returned.

Fixes #2141.

Changeset: 46f9f5be7fc10979c288ceea698dbbf309d08c51

[dustin]

Which is to say, this was a bug in 0.8.5, and the linked patch fixes it.