Opened 8 years ago

Closed 7 years ago

#2126 closed defect (fixed)

buildbot try --properties=prop=value doesn't work with try_jobdir

Reported by: gg0 Owned by:
Priority: major Milestone: 0.8.+
Version: 0.8.5 Keywords: try, sprint
Cc:

Description

try build runs correctly but it doesn't consider the property you pass.

Change History (10)

comment:1 Changed 8 years ago by dustin

I can't replicate. I ran a basic master, then

buildbot try --vc=git -b builder --properties=abc=def,ghi=jkl

and I see properties abc and ghi in the resulting web status, with appropriate values.

comment:2 Changed 8 years ago by gg0

Sorry missing initial info: I usually use Try_Jobdir (ssh). I tried to switch to Try_Userpass (pb) and it works, props are passed correctly.

comment:3 Changed 8 years ago by dustin

  • Milestone changed from undecided to 0.8.6
  • Type changed from undecided to defect

comment:4 Changed 8 years ago by dustin

  • Summary changed from buildbot try --properties=prop=value doesn't work to buildbot try --properties=prop=value doesn't work with try_jobdir

comment:5 Changed 8 years ago by dustin

  • Keywords try added

comment:6 Changed 8 years ago by dlatornell

I've explored this issue a bit. I can confirm that:

buildbot try --connect=ssh --properties=abc=def,ghi=jkl ...

can trigger a build but the properties will not be passed to the builder.

I was expecting to find that the properties had just been dropped somewhere along the chain of events, however, that's not what I found. In short, the properties option is not implemented for the try client when it is used in ssh mode; it's only there for pb mode.

I think the ssh implementation would require handling of properties in the createJobfile function in tryclient.py and the parseJob and handleJobFile methods in trysched.py. The job file format will have to be extended to support key/value pairs.

Unfortunately, I can't devote the time to implement this now. But I thought I should share my findings and opinions.

comment:7 Changed 8 years ago by dustin

  • Keywords sprint added

comment:8 Changed 8 years ago by dustin

  • Milestone changed from 0.8.6 to 0.8.+

comment:9 Changed 8 years ago by Dustin J. Mitchell

Merge branch 'bug2126' of git://github.com/douglatornell/buildbot

Refs #2126.

Changeset: 68a15ba4397da56f11025ee853febe42b482ce19

comment:10 Changed 7 years ago by tom.prince

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.