Opened 6 years ago

Closed 5 years ago

#2116 closed defect (fixed)

gitpoller does not pass environment to git commands

Reported by: msabramo Owned by:
Priority: major Milestone: 0.8.6
Version: master Keywords: git
Cc: msabramo@…

Description

The problem is that gitpoller does not pass the environment to git commands. This is problematic when you have a git repository that is accessed over ssh using an ssh key with a passphrase and you use ssh-agent to cache the keys. In this case, gitpoller does not pass the SSH_AGENT_PID and SSH_AUTH_SOCK environment variables so the git commands to pull down the repo will fail with errors like:

Failure: twisted.internet.utils._UnexpectedErrorOutput: got stderr: 
"fatal: ambiguous argument 'master..origin/master': unknown revision 
or path not in the working tree.
Use '--' to separate paths from revisions
"

I modified my buildbot locally to fix this issue and will send a GitHub? pull request momentarily.

Change History (5)

comment:2 Changed 6 years ago by msabramo

  • Cc msabramo@… added

comment:3 Changed 5 years ago by msabramo

New and improved pull request: https://github.com/buildbot/buildbot/pull/255

comment:4 Changed 5 years ago by msabramo

Merge pull request #255 from msabramo/gitpoller_propagate_env_to_git_2116_2...

ayust merged commit 8d9377d into buildbot:master from msabramo:gitpoller_propagate_env_to_git_2116_2 September 30, 2011

Last edited 5 years ago by msabramo (previous) (diff)

comment:5 Changed 5 years ago by dustin

  • Keywords gitpoller removed
  • Milestone changed from undecided to 0.8.6
  • Resolution set to fixed
  • Status changed from new to closed

Thanks!

Note: See TracTickets for help on using tickets.