Ticket #2111 (closed defect: fixed)

Opened 20 months ago

Last modified 16 months ago

Triggerable sheduler does not inherit Blamelist or Changes from upstream timed.Nightly scheduler

Reported by: garmstrong Owned by:
Priority: major Milestone: 0.8.6
Version: 0.8.5 Keywords:
Cc:

Description

Previously in Buildbot 0.8.4p2 and earlier a quick or full build initiated by a Triggerable scheduler would inherit the Blamelist and Changes from its upstream timed.Nightly scheduler. This is no longer the case in Buildbot 0.8.5. In my particular case, this leads to a reporting issue when builds fails as the mail sent by the MailNotifier? contains no information on possible suspects. The parts of the build managed by the upstream timed.Nightly schedulers do contain the Blamelist and associated changes.

Change History

comment:1 Changed 20 months ago by dustin

  • Milestone changed from undecided to 0.8.6

comment:2 Changed 16 months ago by dustin

  • Status changed from new to closed
  • Resolution set to fixed

Ah, the bug is actually in sourcestamp.py. getAbsoluteSourceStamp passes _ignoreChanges so that the revision, branch, etc. are not set from the changes -- however, that is taken to mean that changes should not be kept at all, which is incorrect.

  • master/buildbot/sourcestamp.py 

    commit 4f60e25e1bb85b7b8853f83b3af68607f9190026
Author: Dustin J. Mitchell <dustin@mozilla.com>
Date:   Fri Jan 13 20:25:31 2012 -0600

   set self.changes even with _ignoreChanges

diff --git a/master/buildbot/sourcestamp.py b/master/buildbot/sourcestamp.py
index e7c3fb9..a81ef56 100644
    a b class SourceStamp(util.ComparableMixin, styles.Versioned): 
    145145       self.patch_info = patch_info 
    146146       self.project = project or '' 
    147147       self.repository = repository or '' 
    148         if changes and not _ignoreChanges: 
     148        if changes: 
    149149           self.changes = tuple(changes) 
     150        if changes and not _ignoreChanges: 
    150151           # set branch and revision to most recent change 
    151152           self.branch = changes[-1].branch 
    152153           revision = changes[-1].revision 
Note: See TracTickets for help on using tickets.