Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#2097 closed defect (fixed)

new Git step fails with exception rather than failure.

Reported by: tom.prince Owned by:
Priority: major Milestone: 0.8.5
Version: master Keywords: git
Cc: in3xes

Attachments (2)

5-log-git-stdio (3.0 KB) - added by tom.prince 9 years ago.
stdio log
5-log-git-err.text (70 bytes) - added by tom.prince 9 years ago.
Exception

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by tom.prince

stdio log

Changed 9 years ago by tom.prince

Exception

comment:1 Changed 9 years ago by dustin

  • Cc in3xes added
  • Milestone changed from undecided to 0.8.5

comment:2 Changed 9 years ago by dustin

This looks like a wider problem -- I see raise failure.Failure(rc) (or, worse, raise failure.Failure) in a number of places in the new code. This will need to be the local equivalent of AbandonChain, although I'm not sure exactly what that is!

comment:3 Changed 9 years ago by tom.prince

It also doesn't seem to always respond promptly to interruption requests.

comment:4 Changed 9 years ago by Dustin J. Mitchell

  • Resolution set to fixed
  • Status changed from new to closed

Handle errors in master-side source steps

This adds a BuildStepFailed? exception that can be raised within anything that leads to step.failed; from there, it will be punted to step.finished(FAILURE). Fixes #2097.

Changeset: 6cd2ceac5ff6fbb74fedb2855381051546b40f13

comment:5 Changed 9 years ago by Dustin J. Mitchell

Handle errors in master-side source steps

This adds a BuildStepFailed? exception that can be raised within anything that leads to step.failed; from there, it will be punted to step.finished(FAILURE). Fixes #2097.

Changeset: a076b445b2e80ed7da3df4d3b7b9430f42a4a879

Note: See TracTickets for help on using tickets.