![[Buildbot Logo]](/chrome/site/header-text-transparent.png)
Ticket #2060 (closed enhancement: fixed)
Trial's tests parameter doesn't accept Property objects
| Reported by: | dwyerk | Owned by: | bdbaddog |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.8.5 |
| Version: | 0.8.4p1 | Keywords: | simple |
| Cc: |
Description
buildbot.steps.python_twisted.Trial(tests=Property('my_tests')) causes an exception at python_twisted.py:411 in start():
self.command.extend(self.tests)
exceptions.TypeError?: iteration over non-sequence
I was able to work around it by subclassing Trial and defining a renderables class variable that appended "tests" to Trial.renderables, but I can't tell if that's the appropriate fix.
Change History
comment:1 Changed 22 months ago by dustin
- Keywords simple added
- Milestone changed from undecided to 0.8.5
comment:3 Changed 22 months ago by bdbaddog
How would one create a test for this? (If one were doing TDD)..
comment:4 Changed 22 months ago by dwyerk
Probably something similar to: https://github.com/buildbot/buildbot/blob/master/master/buildbot/test/regressions/test_shell_command_properties.py
It might be possible to more generically and widely test that all of the buildsteps can take properties for each of their arguments, but that's probably not trivial.
comment:5 Changed 22 months ago by bdbaddog
- Owner set to bdbaddog
- Status changed from new to accepted
comment:7 Changed 21 months ago by William Deegan
- Status changed from accepted to closed
- Resolution set to fixed
Fixed ticket 2060: python_twisted Trial step can now take a property for the value of tests. Note that tests expects a list, so WithProperties? doesn't seem to work
Changeset: 5cb1afce3ad911826b1da6178abd56298d9a73a8
comment:8 Changed 21 months ago by Dustin J. Mitchell
Merge branch 'bug_2060' of git://github.com/bdbaddog/buildbot
- 'bug_2060' of git://github.com/bdbaddog/buildbot: Fixed ticket 2060: python_twisted Trial step can now take a property for the value of tests. Note that tests expects a list, so WithProperties? doesn't seem to work
Merge includes a pyflakes fix.
Changeset: 077078052a1fe259d31b081d9df60ff5e15fec01