Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#2051 closed defect (fixed)

Triggerable exception on shutdown

Reported by: dustin Owned by:
Priority: major Milestone: 0.8.5
Version: 0.8.4p1 Keywords:
Cc:

Description

2011-07-13 17:22:26-0700 [-] Received SIGTERM, shutting down.
2011-07-13 17:22:26-0700 [-] Unhandled error in Deferred:
2011-07-13 17:22:26-0700 [-] Unhandled Error
        Traceback (most recent call last):
          File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 133, in maybeDeferred
            result = f(*args, **kw)
          File "/usr/lib/python2.7/site-packages/twisted/application/service.py", line 285, in stopService
            l.append(defer.maybeDeferred(service.stopService))
          File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 133, in maybeDeferred
            result = f(*args, **kw)
          File "/usr/lib/python2.7/site-packages/twisted/application/service.py", line 285, in stopService
            l.append(defer.maybeDeferred(service.stopService))
        --- <exception caught here> ---
          File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 133, in maybeDeferred
            result = f(*args, **kw)
          File "/var/lib/buildbot/prod_084/lib/python2.7/site-packages/buildbot/schedulers/triggerable.py", line 66, in stopService
            d.errback(failure.Failure(RuntimeError(msg)))
        exceptions.AttributeError: 'int' object has no attribute 'errback'
        
2011-07-13 17:22:26-0700 [-] (TCP Port 8080 Closed)
2011-07-13 17:22:26-0700 [-] Stopping factory <buildbot.status.web.baseweb.RotateLogSite instance at 0x2872d40>
2011-07-13 17:22:26-0700 [-] (TCP Port 9998 Closed)
2011-07-13 17:22:26-0700 [-] Stopping factory <twisted.conch.manhole_ssh.ConchFactory instance at 0x2e47128>
2011-07-13 17:22:26-0700 [-] (TCP Port 9989 Closed)
2011-07-13 17:22:26-0700 [-] Stopping factory <twisted.spread.pb.PBServerFactory instance at 0x2e5c1b8>

Attachments (1)

fix_triggerable.patch (651 bytes) - added by dwlocks 9 years ago.
use the value, not the key in _waiters

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by dwlocks

use the value, not the key in _waiters

comment:1 Changed 9 years ago by Dustin J. Mitchell

  • Resolution set to fixed
  • Status changed from new to closed

Correctly notify waiters when a Triggerable shuts down

Fixes #2051

Changeset: 26bdbcec654a1f3517fedd9a78512221ebaca04d

comment:2 Changed 9 years ago by Dustin J. Mitchell

Correctly notify waiters when a Triggerable shuts down

Fixes #2051

Changeset: c8bcb29d2a240087a3db2bee42abf986989887a1

Note: See TracTickets for help on using tickets.