Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#2049 closed defect (fixed)

Broken parsing in pylint

Reported by: dwyerk Owned by:
Priority: minor Milestone: 0.8.5
Version: 0.8.4p1 Keywords:
Cc:

Description

The change shown here https://github.com/buildbot/buildbot/commit/d013e2ce85aaf8a8e5378edb716f72abf3cef76b breaks pylint when using the option include-ids=yes in your pylintrc. What you really want is to make those d{4}'s optional.

Change History (5)

comment:1 Changed 9 years ago by dustin

Can you give some example strings so that we can test this?

comment:2 Changed 9 years ago by dustin

  • Milestone changed from undecided to 0.8.5
  • Priority changed from major to minor

comment:3 Changed 9 years ago by dwyerk

include-ids=yes, output-format=parseable

test.py:1: [C0103, whatABadFunctionName] Invalid name "whatABadFunctionName" (should match [a-z_][a-z0-9_]{2,30}$)

include-ids=no, output-format=parseable

test.py:1: [C, whatABadFunctionName] Invalid name "whatABadFunctionName" (should match [a-z_][a-z0-9_]{2,30}$)

include-ids=yes, output-format=text

C0103:  1:whatABadFunctionName: Invalid name "whatABadFunctionName" (should match [a-z_][a-z0-9_]{2,30}$)

include-ids=no, output-format=text

C:  1:whatABadFunctionName: Invalid name "whatABadFunctionName" (should match [a-z_][a-z0-9_]{2,30}$)

comment:4 Changed 9 years ago by Andi Albrecht

  • Resolution set to fixed
  • Status changed from new to closed

Update PyLint? regular expression.

PyLint? adds column offsets to text output in 0.24.0. In addition this change fixes #2049 too by adding an optional d{4} to match ids in case pylint was called with "--include-ids=y".

Changeset: 906ae7773869d8365f05e614ce2070d202332bad

comment:5 Changed 9 years ago by Amber Yust

Merge pull request #222 from andialbrecht/master

Update PyLint? regex (fixes #2049 too)

Changeset: 483cc19817eb895fea9ee3d785430664a7b7cfa1

Note: See TracTickets for help on using tickets.