Opened 8 years ago

Closed 8 years ago

#2043 closed defect (fixed)

Upgrades from 0.8.3 get column lengths wrong

Reported by: dustin Owned by:
Priority: critical Milestone: 0.8.5
Version: 0.8.4p1 Keywords: database
Cc:

Description

From 0.8.3:

===============================================================================
[FAIL]
Traceback (most recent call last):
  File "/home/dustin/code/buildbot/t/buildbot/master/buildbot/test/integration/test_upgrade.py", line 91, in check
    self.fail(str(diff))
twisted.trial.unittest.FailTest: Schema diffs:
  tables missing from model: sqlite_sequence
  tables missing from database: version
  table with differences: changes
    column with differences: branch
         model: Column('branch', String(length=256, convert_unicode=False, assert_unicode=None, unicode_error=None, _warn_on_bytestring=False), table=<changes>)
      database: Column(u'branch', VARCHAR(length=1024, convert_unicode=False, assert_unicode=None, unicode_error=None, _warn_on_bytestring=False), table=<changes>)
    column with differences: author
         model: Column('author', String(length=256, convert_unicode=False, assert_unicode=None, unicode_error=None, _warn_on_bytestring=False), table=<changes>, nullable=False)
      database: Column(u'author', VARCHAR(length=1024, convert_unicode=False, assert_unicode=None, unicode_error=None, _warn_on_bytestring=False), table=<changes>, nullable=False)
  table with differences: schedulers
    column with differences: class_name
         model: Column('class_name', String(length=128, convert_unicode=False, assert_unicode=None, unicode_error=None, _warn_on_bytestring=False), table=<schedulers>, nullable=False)
      database: Column(u'class_name', VARCHAR(length=100, convert_unicode=False, assert_unicode=None, unicode_error=None, _warn_on_bytestring=False), table=<schedulers>, nullable=False)
    column with differences: name
         model: Column('name', String(length=128, convert_unicode=False, assert_unicode=None, unicode_error=None, _warn_on_bytestring=False), table=<schedulers>, nullable=False)
      database: Column(u'name', VARCHAR(length=100, convert_unicode=False, assert_unicode=None, unicode_error=None, _warn_on_bytestring=False), table=<schedulers>, nullable=False)

buildbot.test.integration.test_upgrade.UpgradeTestV083.test_test
-------------------------------------------------------------------------------

Change History (1)

comment:1 Changed 8 years ago by dustin

  • Resolution set to fixed
  • Status changed from new to closed

Fixed:

commit c9d763658ca922d4659b978874dc1c5824686bfb
Author: Dustin J. Mitchell <dustin@mozilla.com>
Date:   Sun Jul 10 15:03:39 2011 -0500

    Set correct column sizes on changes and schedulers tables
    
    These were set incorrectly by the old upgrade scripts.  This commit also
    adds tests for upgrades from 0.8.2 and 0.8.3.
Note: See TracTickets for help on using tickets.