Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#2042 closed defect (fixed)

remove schedulers.state column

Reported by: dustin Owned by:
Priority: major Milestone: 0.8.5
Version: 0.8.4p2 Keywords: database, simple
Cc:

Description

This is no longer used - schedulers now store their state in the object_state table.

Change History (6)

comment:1 Changed 9 years ago by dustin

  • Keywords simple added
  • Version changed from 0.8.4p1 to 0.8.4p2

comment:2 Changed 9 years ago by bdbaddog

Is this the right docs to refer to for working on this logic:

http://packages.python.org/sqlalchemy-migrate/versioning.html#create-a-change-script

comment:3 Changed 9 years ago by bdbaddog

comment:4 Changed 9 years ago by dustin

  • Type changed from enhancement to defect

There's still some work to do here:

  • remove the methods from master.db.schedulers
  • remove the state-management methods from BaseScheduler?
  • fix Timed to not use state
    • update the corresponding migration script

comment:5 Changed 9 years ago by Dustin J. Mitchell

  • Resolution set to fixed
  • Status changed from new to closed

Finish removing schedulers.state column

The Nightly scheduler was still expecting scheduler state, and as such would fail without the column. This removes a bunch of now-dead code, and re-implements the BaseScheduler? get/setState methods to use the master.db.state, along with updated tests. Fixes #2042.

Changeset: d8c2d1b1f5527c6d336b1c8278fee1eb34ff5529

comment:6 Changed 9 years ago by Dustin J. Mitchell

Finish removing schedulers.state column

The Nightly scheduler was still expecting scheduler state, and as such would fail without the column. This removes a bunch of now-dead code, and re-implements the BaseScheduler? get/setState methods to use the master.db.state, along with updated tests. Fixes #2042.

Changeset: cc11223d873b0c835b06e67cc7e21749a8cad763

Note: See TracTickets for help on using tickets.