rmdir slaveside command return 0 even if it fails

[in3xes]

 https://github.com/buildbot/buildbot/blob/master/slave/buildslave/commands/fs.py#L91

Ideally it should send whatever the command returns.

after digging little deeper, _abandonOnFailure is also not catching it. because of '-f' on argument in 'rm -rf' returns 0 if path of the file specified is invalid.

[dustin]

Probably the right error-handling technique is to test for existence of the pathname after 'rm' returns, and set rc=1 if the pathname still exists.

[dustin]

Pradeep, will you have a chance to fix this?

[in3xes]

This is report is kind of wrong too. I tried to fix this when I modified rmdir's behavior. I couldn't because there was nothing to fix.

I wrote - It returns 0 even if the path is invalid. I think in this case it is ok return 0, because there's nothing to delete. A fix like checking for the path exists or not wouldn't catch that either. Before reporting I thought it was not returning the correct value, but it was. I think we can close this.

[dustin]

That's easy - thanks for looking into it!