Ticket #2031 (closed defect: fixed)

Opened 23 months ago

Last modified 23 months ago

buildbot try --with-properties truncates property vals with '='

Reported by: rmorison Owned by:
Priority: minor Milestone: 0.8.5
Version: 0.8.4p1 Keywords:
Cc:

Description

E.g.

--with-properties=FLAGS=V=1

passes 'FLAGS':'V', instead of 'FLAGS':'V=1'

Simple patch fixes this: 

--- scripts/runner.py   2011-06-30 15:20:42.690032071 -0700
+++ scripts/runner-fix.py       2011-06-30 15:16:33.970031595 -0700
@@ -1042,7 +1042,7 @@
         propertylist = option.split(",")
         for i in range(0,len(propertylist)):
             print propertylist[i]
-            splitproperty = propertylist[i].split("=")
+            splitproperty = propertylist[i].split("=", 1)
             properties[splitproperty[0]] = splitproperty[1]
         self['properties'] = properties

Change History

comment:1 Changed 23 months ago by dustin

  • Keywords try property removed
  • Milestone changed from undecided to 0.8.5

comment:2 Changed 23 months ago by Dustin J. Mitchell

  • Status changed from new to closed
  • Resolution set to fixed

Allow try --properties with '=' in value

And add a whole mess of tests, and clean up option handling significantly. Fixes #2031.

Changeset: 78da9f9e7d52b7cf851d9d019c5560939d20a784

Note: See TracTickets for help on using tickets.