(more) email breakage in 0.8.4p1

[dberger]

2011-06-29 07:45:22-0700 [-] Exception caught notifying <buildbot.status.mail.MailNotifier instance at 0x02CA7350> of buildFinished event
2011-06-29 07:45:22-0700 [-] Unhandled Error
	Traceback (most recent call last):
	  File "E:uild_masterexternaluildbot-0.8.4p1uildbotstatusuild.py", line 288, in buildFinished
	    w.callback(self)
	  File "E:uild_masterexternalTwisted-11.0.0	wistedinternetdefer.py", line 361, in callback
	    self._startRunCallbacks(result)
	  File "E:uild_masterexternalTwisted-11.0.0	wistedinternetdefer.py", line 455, in _startRunCallbacks
	    self._runCallbacks()
	  File "E:uild_masterexternalTwisted-11.0.0	wistedinternetdefer.py", line 542, in _runCallbacks
	    current.result = callback(current.result, *args, **kw)
	--- <exception caught here> ---
	  File "E:uild_masterexternaluildbot-0.8.4p1uildbotstatusuilder.py", line 541, in _buildFinished
	    w.buildFinished(name, s, results)
	  File "E:uild_masterexternaluildbot-0.8.4p1uildbotstatusmail.py", line 410, in buildFinished
	    return self.buildMessage(name, [build], results)
	  File "E:uild_masterexternaluildbot-0.8.4p1uildbotstatusmail.py", line 593, in buildMessage
	    results, builds, patches, logs)
	  File "E:uild_masterexternaluildbot-0.8.4p1uildbotstatusmail.py", line 545, in createEmail
	    k = builds[0].render(k)
	exceptions.AttributeError: BuildStatus instance has no attribute 'render'

[dustin]

Sigh. This is what comes of modifying un-tested (or, in this case, badly-tested) code.

[dberger]

it looks like the author expects that to be a Build object (rather than a BuildStatus?) object - but I don't see a way to get from what he's got to what he wants.

[Dustin J. Mitchell]

Add a hasProperties method to builds

This better-defines the interface of the object passed to WithProperties? callables, including a hasProperties method; fixes MailNotifier? to render properties properly in extraHeaders; and adds a lot of tests.

Fixes #2024 and Fixes #2021.

Changeset: 5468cc2fb22a0559bf0fd2cfc51ecd17c2b511e7

[Dustin J. Mitchell]

0.8.4 Branch fixups for properties

Do not render properties in MailNotifier? extraHeaders (Refs #2021)

Make the WithProperties? callable example work (Refs #2024)

Changeset: ee833ea79f42dfb182a98b86e068d62510098a79