Ticket #2003 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

SingleBranchScheduler not available from buildbot.scheduler

Reported by: adamcollard Owned by:
Priority: minor Milestone: 0.8.5
Version: 0.8.4p1 Keywords:
Cc:

Description

After upgrading to 0.8.4, I fixed the WARNINGs from a reconfig and renamed Scheduler to SingleBranchScheduler?.

This didn't work, since Scheduler came from buildbot.scheduler, and SingleBranchScheduler? is only available in buildbot.schedulers.basic.

This could either be a case for enhancing the docs to highlight the difference, or (preferred from my point of view) adding SingleBranchScheduler? to buildbot.scheduler

Change History

comment:1 Changed 2 years ago by dustin

I'd actually rather improve the docs and the error message - I don't want folks importing from buildbot.scheduler anymore.

comment:2 Changed 2 years ago by dustin

  • Type changed from undecided to defect
  • Milestone changed from undecided to 0.8.5

comment:3 Changed 2 years ago by Dustin J. Mitchell

  • Status changed from new to closed
  • Resolution set to fixed

Point to new import location in warning for Scheduler

This gives better hints to lead users to find the new SingleBranchScheduler? in buildbot.schedulers.basic rather than buildbot.scheduler. Fixes #2003.

Changeset: a17b1833c8d0afead53b01dc14805d8581f4cb6d

Note: See TracTickets for help on using tickets.