suppressionFile causes traceback on slave

[pworach]

2011-06-19 16:23:22+0000 [-] command finished with signal None, exit code 0, elapsedTime: 22.841655
2011-06-19 16:23:22+0000 [-] SlaveBuilder.commandComplete <buildslave.commands.shell.SlaveShellCommand instance at 0x803b82ea8>
2011-06-19 16:23:22+0000 [Broker,client] Peer will receive following PB traceback:
2011-06-19 16:23:22+0000 [Broker,client] Unhandled Error
	Traceback (most recent call last):
	  File "/usr/local/lib/python2.7/site-packages/twisted/spread/banana.py", line 153, in gotItem
	    self.callExpressionReceived(item)
	  File "/usr/local/lib/python2.7/site-packages/twisted/spread/banana.py", line 116, in callExpressionReceived
	    self.expressionReceived(obj)
	  File "/usr/local/lib/python2.7/site-packages/twisted/spread/pb.py", line 514, in expressionReceived
	    method(*sexp[1:])
	  File "/usr/local/lib/python2.7/site-packages/twisted/spread/pb.py", line 826, in proto_message
	    self._recvMessage(self.localObjectForID, requestID, objectID, message, answerRequired, netArgs, netKw)
	--- <exception caught here> ---
	  File "/usr/local/lib/python2.7/site-packages/twisted/spread/pb.py", line 840, in _recvMessage
	    netResult = object.remoteMessageReceived(self, message, netArgs, netKw)
	  File "/usr/local/lib/python2.7/site-packages/twisted/spread/flavors.py", line 114, in remoteMessageReceived
	    state = method(*args, **kw)
	  File "/usr/local/lib/python2.7/site-packages/buildslave/bot.py", line 136, in remote_startCommand
	    self.command = factory(self, stepId, args)
	  File "/usr/local/lib/python2.7/site-packages/buildslave/commands/base.py", line 135, in __init__
	    self.setup(args)
	  File "/usr/local/lib/python2.7/site-packages/buildslave/commands/transfer.py", line 68, in setup
	    self.keepstamp = args['keepstamp']
	exceptions.KeyError: 'keepstamp'
	
2011-06-19 16:31:30+0000 [-] sending app-level keepalive

The step is:

    WarningCountingShellCommand(name="compile-freebsd-world",
                                command=["make", WithProperties("-j%(jobs)s"), "
buildworld", "NO_WERROR=", "NO_CLEAN=", "WITHOUT_LIB32=", "WITHOUT_PROFILE="],
                                env={'__MAKE_CONF' : '/dev/null',
                                     'CC' : WithProperties("/data/buildslave/%(b
uildername)s/obj/obj-llvm.2/Release+Asserts/bin/clang"),
                                     'CXX' : WithProperties("/data/buildslave/%(
buildername)s/obj/obj-llvm.2/Release+Asserts/bin/clang++"),
                                     'MAKEOBJDIRPREFIX' : WithProperties("/data/
buildslave/%(buildername)s/obj/obj-freebsd"),},
                                workdir="src-freebsd", haltOnFailure=True,
                                suppressionFile="../../warnings.supp",
                                description=["compiling freebsd", "world"],
                                descriptionDone=["compile freebsd", "world"]),

[dustin]

It looks like [7c4eb59d6ef0db0de91f8d0673fe7793e7eb978c]

Author: nate <nate.bragg@adb-air.com>
Date:   Wed May 11 14:56:10 2011 -0400

    Added optional keepstamp argument for FileUpload buildstep, that,
    when True, forces the timestamp of the destination file to match
    the source file.

should have made the argument optional on the slave side. Easy enough to fix, although this will still be a problem for 0.8.4 slaves.

[Dustin J. Mitchell]

Make the keepstamp uploadFile argument optionsl

This command is used not just from UploadFile? steps, but from WarningCountingShellCommand? and, soon, from source steps.

This was my fault for not being careful about protocol changes. Fixes #1995.

Changeset: 230e71d9329ab2d331c817ea8b0a063f4a41263f