Ticket #1987 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

sendchange fails with TypeError

Reported by: Underhand Owned by:
Priority: major Milestone: 0.8.5
Version: master Keywords:
Cc:

Description (last modified by dustin) (diff)

With the latest version from the master branch, downloaded today from github, attempting to run sendchange gives the following error. 

-bash-4.2$ buildbot sendchange --master 'localhost:9989' --who testuser --branch test a b
Traceback (most recent call last):
  File "/usr/pkg/bin/buildbot", line 4, in <module>
    runner.run()
  File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py", line 1234, in run
    if not sendchange(so, True):
  File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py", line 898, in sendchange
    revlink=revlink)
  File "/usr/pkg/lib/python2.6/site-packages/buildbot/clients/sendchange.py", line 40, in send
    change['files'][i] = file.decode(self.encoding, 'replace')
TypeError: 'tuple' object does not support item assignment

Without specifying any files, I get this instead:

-bash-4.2$ buildbot sendchange --master 'localhost:9989' --who testuser --branch test
Traceback (most recent call last):
  File "/usr/pkg/bin/buildbot", line 4, in <module>
    runner.run()
  File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py", line 1234, in run
    if not sendchange(so, True):
  File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py", line 904, in sendchange
    d.addCallbacks(s.printSuccess, failed)
AttributeError: Sender instance has no attribute 'printSuccess'

Change History

comment:1 Changed 2 years ago by dustin

  • Description modified (diff)
  • Milestone changed from undecided to 0.8.5

comment:2 Changed 2 years ago by Dustin J. Mitchell

  • Status changed from new to closed
  • Resolution set to fixed

ensure that ch.files is a list before trying to modify

sendchange, in particular, gets tuples from getopt. Fixes #1987.

Changeset: cca26b841cb3ffa042eabb69f82a9e0937bc1162

comment:3 Changed 2 years ago by Dustin J. Mitchell

don't use now-missing methods from senchange.Sender

Fixes #1987.

Changeset: 1f5d2574fb91ac9e4f000afead5d8f3746a6c5d6

comment:4 Changed 2 years ago by Dustin J. Mitchell

ensure that ch.files is a list before trying to modify

sendchange, in particular, gets tuples from getopt. Fixes #1987.

Changeset: 835aa01dc18843fc164807dd5a377e07be104f32

comment:5 Changed 2 years ago by Dustin J. Mitchell

don't use now-missing methods from senchange.Sender

Fixes #1987.

Changeset: 3481db11a5fda53fa79242427abb5faa92e5c600

Note: See TracTickets for help on using tickets.