Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#195 closed enhancement (fixed)

Add functions to the xmlrpc server

Reported by: etienne Owned by: dustin
Priority: patches-accepted Milestone: 0.7.8
Version: 0.7.6 Keywords: xmlrpc trac
Cc: dustin

Description

In order to create a Trac plugin to integration Buildbot into Trac, I've used xmlrpc calls provided by the waterfall status. I laked few functions wich I added to buildbot.status.web.xmlrpc.XMLRPCServer, these are :

  • def xmlrpc_getAllBuilders(self) which returns the list of the

different builders

  • def xmlrpc_getStatus(self, builder_name) which returns the result of

the last build for the given builder

  • def xmlrpc_getLastBuilds(self, builder_name, num_builds) : which is

similar to xmlrpc_getAllBuildsInInterval except that it returns the num_builds last builds for the given builder

Attached is the patch agains version 0.7.6

Attachments (1)

xmlrpc.diff (2.8 KB) - added by etienne 10 years ago.
Patch to add functions

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by etienne

Patch to add functions

comment:1 Changed 10 years ago by dustin

  • Cc dustin added

Looks great! I would ordinarily ask for tests and documentation, but at the moment the XMLRPC stuff is still "experimental", so I think this is a fine addition. If you're feeling adventurous and want to write tests, all the better!

This is available in my branch as #195:xmlrpc-additions.patch.

comment:2 Changed 10 years ago by dustin

  • Owner set to dustin

comment:3 Changed 10 years ago by warner

sounds good. The 'getStatus' method feels misnamed, though, since internally 'getStatus' means to get a status object. How about getLastBuildResults ?

comment:4 Changed 10 years ago by dustin

agreed, and added in #195:getStatus-to-getLastBuildResults.patch

comment:5 Changed 10 years ago by dustin

  • Resolution set to fixed
  • Status changed from new to closed

This is completely merged to brian's tree now.

comment:6 Changed 10 years ago by dustin

  • Milestone changed from undecided to 0.7.8
Note: See TracTickets for help on using tickets.