![[Buildbot Logo]](/chrome/site/header-text-transparent.png)
Ticket #1948 (closed defect: fixed)
WithProperties doesn't interact properly with reconfig
| Reported by: | dabrahams | Owned by: | tom.prince |
|---|---|---|---|
| Priority: | major | Milestone: | 0.8.+ |
| Version: | 0.8.3p1 | Keywords: | reconfig |
| Cc: |
Description
In particular, builders are detected as not having changed when lambdas used with WithProperties? change.
Change History
comment:2 Changed 15 months ago by dustin
- Keywords reconfig added
Probably the correct solution here is to not have builders try to notice that they have been reconfigured, but just use the new configuration directly.
comment:3 Changed 8 months ago by tom.prince
- Owner set to tom.prince
- Status changed from new to assigned
comment:4 Changed 8 months ago by Tom Prince
- Status changed from assigned to closed
- Resolution set to fixed
Make all IRenderables properly comparable.
Compare all renderables using all relevant attributes. Distinctly evaluated lambdas will compare not-equal, so using lambdas for WithProperties? or properties.renderer will work properly with reconfig.
Fixes #1948.
Changeset: 7b982e27ed269fdb9c004ccb0a84e5606b780a89
comment:5 Changed 8 months ago by Tom Prince
Make all IRenderables properly comparable.
Compare all renderables using all relevant attributes. Distinctly evaluated lambdas will compare not-equal, so using lambdas for WithProperties? or properties.renderer will work properly with reconfig.
Fixes #1948.
Changeset: 7b982e27ed269fdb9c004ccb0a84e5606b780a89