Can not trigger build when I use timed.Nightly with onlyIfChanged=True,using GerritChangeSource

[clino]

when I turn onlyIfChanged to True,it will not trigger build action. And I can see the changes in waterfall view of buildbot,when I go to see the twisted.log,I saw every GerritChange? go with a exception(see the log below)

Version Information

Buildbot: 0.8.4-pre-511-g640ee58 Twisted: 11.0.0 Jinja: 2.5.5 Python: 2.6.5 (r265:79063, Apr 16 2010, 13:57:41) [GCC 4.4.3] Buildmaster platform: linux2

exception in log:

2011-04-27 15:38:23+0800 [-] gerrit: {"type":"ref-updated","submitter":{"name":" huangxuan","email":"huangxuan@mycompany.com"},"refUpdate":{"oldRev":"2009df6b7cfc0a0806f1b3718aabb10a2c1c4ba5","newRev":"e11cb20347489ca3fc96aaadfcc4b11be9a50aa5","refName":"myphoneboard","project":"platform/frameworks/base"}}
2011-04-27 15:38:23+0800 [-] gerrit: {"type":"change-merged","change":{"project":"platform/frameworks/base","branch":"myphoneboard","id":"I1b809167880260dc82f395175adb7323bf073a66","number":"17","subject":"change BT local name to "Mycompany A60"","owner":{"name":" huangxuan","email":"huangxuan@mycompany.com"},"url":"http://10.125.3.11:8080/17"},"patchSet":{"number":"1","revision":"e11cb20347489ca3fc96aaadfcc4b11be9a50aa5","ref":"refs/changes/17/17/1","uploader":{"name":" huangxuan","email":"huangxuan@mycompany.com"}},"submitter":{"name":" huangxuan","email":"huangxuan@mycompany.com"}}
2011-04-27 15:38:23+0800 [-] Unhandled error in Deferred:
2011-04-27 15:38:23+0800 [-] Unhandled Error
        Traceback (most recent call last):
          File "/usr/local/lib/python2.6/dist-packages/Twisted-10.0.0-py2.6-linux-x86_64.egg/twisted/internet/process.py", line 260, in dataReceived
            self.proc.childDataReceived(self.name, data)
          File "/usr/local/lib/python2.6/dist-packages/Twisted-10.0.0-py2.6-linux-x86_64.egg/twisted/internet/process.py", line 891, in childDataReceived
            self.proto.childDataReceived(name, data)
          File "/usr/local/lib/python2.6/dist-packages/Twisted-10.0.0-py2.6-linux-x86_64.egg/twisted/internet/protocol.py", line 548, in childDataReceived
            self.outReceived(data)
          File "/usr/local/lib/python2.6/dist-packages/Twisted-10.0.0-py2.6-linux-x86_64.egg/twisted/internet/defer.py", line 964, in unwindGenerator
            return _deferGenerator(f(*args, **kwargs), Deferred())
        --- <exception caught here> ---
          File "/usr/local/lib/python2.6/dist-packages/Twisted-10.0.0-py2.6-linux-x86_64.egg/twisted/internet/defer.py", line 866, in _deferGenerator
            result = g.next()
          File "/usr/local/lib/python2.6/dist-packages/buildbot-0.8.4_pre_511_g640ee58-py2.6.egg/buildbot/changes/gerritchangesource.py", line 81, in outReceived
            wfd = defer.waitForDeferred(d)
          File "/usr/local/lib/python2.6/dist-packages/Twisted-10.0.0-py2.6-linux-x86_64.egg/twisted/internet/defer.py", line 839, in __init__
            raise TypeError("You must give waitForDeferred a Deferred. You gave it %r." % (d,))
        exceptions.TypeError: You must give waitForDeferred a Deferred. You gave it None.

[clino]

It is onlyIfChanged=True,I make a mistake.

[Dustin J. Mitchell]

always return a Deferred from GerritChangeSource?.lineReceived

Fixes #1939.

Changeset: 14869e5a7ebda19346c3bff87d0e535371f22c72

[clino]

Now the exception not happen,but GerritChangeSource? still do not trigger building And I change to SingleBranchScheduler? or AnyBranchScheduler?,it does not trigger building.

Or I have to do more before I use GerritChangeSource??

[dustin]

You may need to configure your schedulers to look for the changes coming from GerritChangeSource. Check with the mailing list or on IRC, or open a new bug.