Opened 4 years ago

Closed 4 years ago

#1932 closed enhancement (duplicate)

property value can't have space if submitted from "Force build" or "Resubmit build" form

Reported by: liucougar Owned by:
Priority: minor Milestone:
Version: 0.8.3p1 Keywords:
Cc:

Description

in file buildbot/status/web/base.py :

def getAndCheckProperties(req):
        ...
        if not re.match(r'^[w.-/~:]*$', pname) 
                or not re.match(r'^[w.-/~:]*$', pvalue):
            log.msg("bad property name='%s', value='%s'" % (pname, pvalue))
            return None

and particular reason to not allow anything in pvalue? (I can understand pname should probably be a valid python identifier, but why put the same limitation on pvalue?

Change History (1)

comment:1 Changed 4 years ago by jmr

  • Resolution set to duplicate
  • Status changed from new to closed

Duplicate of #985.

Note: See TracTickets for help on using tickets.