Opened 7 years ago

Last modified 4 years ago

#1929 new task

refactor BotMaster.cleanShutdown

Reported by: dustin Owned by:
Priority: minor Milestone: 0.9.+
Version: 0.8.3p1 Keywords:
Cc:

Description

This method should

  • repeatedly wait for all running builds to finish, or for shuttingDown == True
  • use some more abstract method to determine whether any builders still have running builds -- the current model digs far too deeply into the status objects, making it hard to test
  • as soon as the shutdown is cancelled, the BuildRequestDistributor should be started back up, rather than waiting for remaining builds to finish.

Change History (4)

comment:1 Changed 7 years ago by dustin

  • Keywords simple removed

comment:2 Changed 6 years ago by tom.prince

  • Milestone changed from 0.8.+ to 0.8.8

comment:3 Changed 5 years ago by dustin

  • Milestone changed from 0.8.8 to 0.9.+

Let's not make any more changes to BRD in the 0.8.x series, please!

comment:4 Changed 4 years ago by tardyp

  • Type changed from enhancement to task

buck started working on this but was interrupted, and will probably dont finish it.

The work is nearly done, and has some small minor fix needed

https://github.com/buildbot/buildbot/pull/861

Note: See TracTickets for help on using tickets.