Opened 6 years ago

Last modified 3 years ago

#1871 assigned defect

Goofy quoting/space handling in buildbot_service.py

Reported by: dabrahams Owned by:
Priority: major Milestone: 0.9.+
Version: 0.8.3p1 Keywords: windows
Cc: rutsky.vladimir@…

Description

If the slave directory has spaces in it, BB gets completely confused if following ​http://trac.buildbot.net/wiki/RunningBuildbotOnWindows

It appears that the directory gets broken up on space boundaries, and if you explicitly add double-quotes to prevent that, the entire string (including quotes) is interpreted as a path _relative_ to buildbot's installation in site-packages/

That wiki page should include 2 prominent warnings about this pitfall until the actual problem is fixed.

Change History (11)

comment:1 Changed 6 years ago by ayust

  • Milestone changed from undecided to 0.8.4

comment:2 Changed 6 years ago by dustin

  • Keywords docs added
  • Milestone changed from 0.8.4 to 0.8.5
  • Type changed from undecided to enhancement

I'm still not skilled enough in Windows to understand this. Wiki editing is free, though :)

comment:3 Changed 6 years ago by dabrahams

  • Owner set to dabrahams
  • Status changed from new to assigned

comment:4 Changed 6 years ago by dabrahams

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:5 Changed 6 years ago by dabrahams

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Type changed from enhancement to defect

Oops; the actual problem isn't fixed; I just updated the Wiki

comment:6 Changed 6 years ago by dabrahams

  • Owner changed from dabrahams to djmitche
  • Status changed from reopened to assigned

comment:7 Changed 6 years ago by dabrahams

  • Owner changed from djmitche to dustin

Sorry about the ticket churn; I'm done here now.

comment:8 Changed 6 years ago by dustin

  • Owner dustin deleted

comment:9 Changed 6 years ago by dustin

  • Keywords windows added; docs removed
  • Milestone changed from 0.8.5 to 0.8.+

There's still a bug to fix here - any windows devs are welcome to pick it up! I suspect it has to do with cmd.exe parsing, which I do not understand.

comment:10 Changed 4 years ago by rutsky

  • Cc rutsky.vladimir@… added

comment:11 Changed 3 years ago by dustin

  • Milestone changed from 0.8.+ to 0.9.+

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.