Ticket #1842 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

logfiles apparently not allowed to be a plain string

Reported by: dabrahams Owned by:
Priority: major Milestone: 0.8.4
Version: 0.8.3p1 Keywords:
Cc:

Description 

==> twistd.log <==
       File "/usr/lib/python2.6/site-packages/buildbot/steps/shell.py", line 389, in __init__
            ShellCommand.__init__(self, workdir=workdir, **kwargs)
        File "/usr/lib/python2.6/site-packages/buildbot/steps/shell.py", line 106, in __init__
            LoggingBuildStep.__init__(self, **buildstep_kwargs)
   File "/usr/lib/python2.6/site-packages/buildbot/process/buildstep.py", line 1056, in __init__
     self.logfiles.update(logfiles)
      exceptions.ValueError: dictionary update sequence element #0 has length 1; 2 is required

Attachments

master.cfg Download (5.9 KB) - added by dabrahams 2 years ago.

Change History

comment:1 Changed 2 years ago by dustin

What was your config?

comment:2 Changed 2 years ago by dustin

  • Type changed from defect to support-request

comment:3 Changed 2 years ago by dabrahams

See attached, which works. Changing 

logfiles = dict(testlog=dict(filename='test.log'))

to 

logfiles = 'test.log'

makes it break

Changed 2 years ago by dabrahams

comment:4 Changed 2 years ago by dustin

OK, well, I'll take the "apparently" in the title to mean "according to the docs", because the docs do say that the parameter takes a dictionary, not a string. That said, the error can be detected earlier.

comment:5 Changed 2 years ago by dustin

  • Status changed from new to closed
  • Type changed from support-request to defect
  • Resolution set to fixed
  • Milestone changed from undecided to 0.8.4

Fixed in 0a70c1e9b69e7f8ac9df232d2f65d3b1b2f32f38.

Note: See TracTickets for help on using tickets.