Opened 8 years ago

Last modified 4 years ago

#1830 new enhancement

Add a warning for logfiles if the log file does not exist or is not found

Reported by: darshie Owned by:
Priority: major Milestone: 0.9.+
Version: 0.8.3 Keywords:
Cc:

Description (last modified by dustin)

I've noticed that there is no warning in the logs if i try to read a log file from disk using logfiles.

f.addStep(ShellCommand(
                        command=["make", "test"],
                        logfiles={"disk_log": "/slavebot/testbuild/test.log"}))

In this case if the file cannot be found, an empty file called test.log will be created and added to the waterfall page.

Would be useful to have a warning in the logs so is possible to know if the file exist or not, and troubleshoot why a log file is not displayed in the waterfall page, instead than just showing an empty file.

Thanks

Change History (7)

comment:1 Changed 8 years ago by dustin

  • Description modified (diff)
  • Keywords shellCommand logfiles removed
  • Milestone changed from undecided to 0.8.4

comment:2 Changed 8 years ago by dustin

  • Milestone changed from 0.8.4 to 0.8.5

comment:3 Changed 7 years ago by dustin

  • Summary changed from ER : Add a warning for logfiles if the log file does not exist or is not found to Add a warning for logfiles if the log file does not exist or is not found

comment:4 Changed 7 years ago by callek

Should this show a warning in waterfall of "log {logfilename} not found [details]" or actually be represented as if it is the logfiles contents?

I think the *way* we expose this data matters, and would be relatively representative of how difficult this is to do.

comment:5 Changed 7 years ago by verm

Expressed in the waterfall some how I would think. A 0-byte log file lets the end-user know nothing was logged anything above that may lead to the assumption the correct data was logged rather than a warning/error from buildbot.

comment:6 Changed 6 years ago by dustin

This should probably just cause the buildstep to fail, with a suitable error message.

comment:7 Changed 4 years ago by dustin

  • Milestone changed from 0.8.+ to 0.9.+

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.