![[Buildbot Logo]](/chrome/site/header-text-transparent.png)
Ticket #1827 (closed enhancement: fixed)
Make clean shutdown a buildbot command
| Reported by: | mjw | Owned by: | ewong |
|---|---|---|---|
| Priority: | major | Milestone: | 0.8.8 |
| Version: | 0.8.3p1 | Keywords: | sprint |
| Cc: | ewongbb@… |
Description
Currently you can only do a graceful shutdown of the buildbot through the web status page. It would be nice to be able to do it through the command line too. Just like you can do a buildbot reconfig (if that fails you often want a graceful shutdown or even graceful restart to happen).
Change History
comment:3 Changed 2 years ago by dustin
- Keywords sprint added
- Milestone changed from undecided to 0.8.+
comment:4 Changed 20 months ago by dank
I would like this, too. My bots need to shut down if /var/run/reboot-required is set.
comment:5 Changed 20 months ago by dank
Wait a minute, I think I meant to say this on bug 849, since it's just the slave that needs to shut down for me.
comment:6 Changed 15 months ago by dustin
- Milestone changed from 0.8.+ to 0.8.7
jstultz in IRC just asked about this today.
comment:9 Changed 12 months ago by dustin
- Summary changed from Make graceful shutdown a buildbot command to Make clean shutdown a buildbot command
To clarify this bug, this is for a way to do a "clean shutdown" (that is, of the master, not a slave) from the command line. #849 is for slave-initiated graceful shutdown (of a slave).
So the tricky bit here is inventing a portable way to communicate with the master. Or just picking a new signal (like SIGUSR1?) and admitting that the feature won't work on Windows.
For more general mechanisms, you might have a look at http://buildbot.net/buildbot/docs/latest/manual/installation.html#other-buildslave-configuration which describes how slave-initiated graceful shutdown is triggered.
comment:12 Changed 4 months ago by ewong
- Owner set to ewong
- Status changed from assigned to accepted
comment:13 Changed 3 months ago by dustin
Ewong wrapped this up a while back.
comment:14 Changed 3 months ago by dustin
- Status changed from accepted to closed
- Resolution set to fixed
comment:15 Changed 3 months ago by dank
I think this feature landed in two parts:
commit 4beec2e08a0baa3fee9be66810cc2a8f8c5ecd82 Author: Edmund Wong <ewongbb@…> Date: Wed Sep 12 12:04:07 2012 +0800
- New WIP for Clean shutdown.
added clean shutdown on SIGUSR1.
commit 35a87197b441628ee9690d548b06ec13b0fe43af Author: Dustin J. Mitchell <dustin@…> Date: Sun Feb 10 17:52:38 2013 -0500
support clean restart, too
added a --clean option to 'buildbot stop'.
I don't think either of these have made it into a release yet, so I guess they'll be in 0.8.8?
comment:16 Changed 3 months ago by dustin
Yes, they'll be in the next release, most likely 0.8.8.