Opened 7 years ago

Last modified 4 years ago

#1824 new enhancement

Dependent build depends on scheduler property

Reported by: dustin Owned by:
Priority: critical Milestone: 0.9.+
Version: Keywords: database, sprint
Cc: kshriram18@…


In general, no part of Buildbot has depended on properties except for the got_revision property, and that's ugly. But Dependent is using properties to figure out if a newly submitted buildset is from its upstream scheduler. Is there a better way?

Change History (7)

comment:1 Changed 7 years ago by dustin

This will mean adding a new column to the buildsets table.

Ideally, that would be a schedulerid (or NULL for buildsets not created by a scheduler). The problem is, there can be multiple rows in the schedulers table with the same name and different classes. The other option is a scheduler name, but that seems ugly and denormalized to me.

comment:2 Changed 7 years ago by dustin

  • Milestone changed from 0.8.4 to 0.8.5

schema change -> 0.8.5

comment:3 Changed 5 years ago by dustin

  • Milestone changed from 0.8.+ to 0.9.0

comment:4 Changed 5 years ago by ShriramK

  • Cc kshriram18@… added

comment:5 Changed 5 years ago by dustin

  • Keywords sprint added

We now have a schedulers table with unique id's per scheduler, so this is much more practical.

comment:6 Changed 4 years ago by dustin

  • Version master deleted

So in the new world, each buildset should have the id of the scheduler that created it, and the dependent scheduler should be watching for completed buildsets with its upstream schedulers' id.

comment:7 Changed 4 years ago by tardyp

  • Milestone changed from 0.9.0 to 0.9.+

I dont think its critical for nine. It is for oneoh

Note: See TracTickets for help on using tickets.