Ticket #1808 (closed defect: fixed)

Opened 2 years ago

Last modified 3 months ago

Scheduler with treeStableTimer "merges" changes to multiple projects into single SourceStamp

Reported by: aivarsk Owned by: jaredgrubb
Priority: major Milestone: 0.8.+
Version: 0.8.3p1 Keywords: sprint
Cc:

Description

With treeStableTimer set to some interval Scheduler merges multiple changes regardless of project and repository into single SourceStamp?. SourceStamp? then uses project and repository from last change in list and only the last project gets built.

Attached patch solves it for us, maybe there is a better way to do it.

Attachments

buildbot-treeStable.diff Download (1.4 KB) - added by aivarsk 2 years ago.

Change History

Changed 2 years ago by aivarsk

comment:1 Changed 2 years ago by dustin

We're re-naming Scheduler to SingleBranchScheduler in the next release, as it's really only intended to watch a single branch (and therefore a single proj/repo).

This change may be a good one to make to the AnyBranchScheduler, though - it should keep a separate timer for each (proj,repo,branch).

comment:2 Changed 2 years ago by ayust

  • Milestone changed from undecided to 0.8.4

comment:3 Changed 2 years ago by dustin

  • Milestone changed from 0.8.4 to 0.8.+

comment:4 Changed 16 months ago by dustin

  • Keywords sprint added

comment:5 Changed 15 months ago by jaredgrubb

I have a patch ready for this; I still need to test this on an actual production buildmaster, since the unit tests only test against a fake db.

comment:6 Changed 15 months ago by jaredgrubb

  • Owner set to jaredgrubb
  • Status changed from new to assigned

comment:7 Changed 13 months ago by tom.prince

ping

comment:8 Changed 9 months ago by tom.prince

ping

comment:9 Changed 4 months ago by dustin

I'm guessing Jared's not working on this.

The easy bit here is making AnyBranchScheduler? use a tuple (proj,repo,branch) instead of just a branch. The harder bits are making it backward-compatible without adding complexity, and handling change classification.

comment:10 Changed 4 months ago by jaredgrubb

Wow, I totally dropped the ball on this.

Anyway, I do have a patch, and surprisingly it still applies cleanly. However I havent tested it except in unit tests.

comment:11 Changed 4 months ago by Jared Grubb

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixes #1808: use different treeStableTimer in AnyBranchScheduler? for different sources

Changeset: 066b0e54554e6a52c873a3d703b309184225d081

comment:12 Changed 3 months ago by Jared Grubb

Fixes #1808: use different treeStableTimer in AnyBranchScheduler? for different sources

Changeset: 066b0e54554e6a52c873a3d703b309184225d081

Note: See TracTickets for help on using tickets.