Ticket #177 (closed defect: fixed)

Opened 4 years ago

Last modified 14 months ago

2nd source.SVN build step picks up incorrect branch

Reported by: mmcdougall Owned by:
Priority: major Milestone: 0.8.1
Version: 0.7.6 Keywords: projrepo, svn
Cc: john@…, dustin, warner

Description

I have two important sub-directories that I want on my build slave -- buildscripts and archive. When I used the source.SVN build step to attempt to deploy these two folders, the second folder got the incorrect branch:

f.addStep( 

source.SVN,  baseURL=" svn+ssh://buildbot@ss.mycompany.com/svn/branches/jgale/",  defaultBranch="buildbot-build-archive",  directory="./build/archive",  haltOnFailure = 1  ) 

f.addStep( 

source.SVN,  baseURL=" svn+ssh://buildbot@ss.mycompany.com/svn/branches/jgale/",  defaultBranch="buildbot-buildscripts",  directory="./build/buildscripts",  haltOnFailure = 1  ) 

-- RESULTS IN -->

/usr/bin/svn checkout --revision 18837 --non-interactive  svn+ssh://buildbot@ss.mycompany.com/svn/branches/jgale/buildbot-build-archive archive /usr/bin/svn checkout --revision 18837 --non-interactive  svn+ssh://buildbot@ss.mycompany.com/svn/branches/jgale/buildbot-build-archive buildscripts

-- NOTE --> In the second checkout, I am getting the "archive" bits of my source repository, rather than the "buildscripts" bits of my source directory

Change History

comment:1 Changed 4 years ago by smadness

  • Cc john@… added

comment:2 Changed 4 years ago by dustin

  • Cc dustin added

comment:3 Changed 3 years ago by dustin

  • Cc warner added

This is because you're specifying defaultBranch, which is being overridden by the branch from the ChangeSource.

It doesn't look like it's possible to do what you want right now, from my read of the code. Want to write up a patch?

comment:4 Changed 3 years ago by mmacvicar

I am also having this problem. I have at least 4 SVN buildsteps pulling from different places, sometimes it works, othe times the first steps is redirected to the changesource (thanks for pointing that out). I'll see if I can understand it enough to patch it.

I can probably work around it by using ShellCommand?( command = ['svn', 'up'...).

comment:5 Changed 3 years ago by dustin

  • Milestone changed from undecided to 0.7.+

comment:6 Changed 21 months ago by dustin

  • Keywords projrepo added
  • Milestone changed from 0.8.+ to 0.8.1

comment:7 Changed 18 months ago by dustin

  • Keywords projrepo, svn added; projrepo removed
  • Milestone changed from 0.8.2 to 0.8.+

comment:8 Changed 14 months ago by dustin

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from 0.8.+ to 0.8.1

I *think* this is fixed in [c876363fe664fb9fa991f91d5b2c672639bd5a88], which was actually merged in 0.8.1. Please re-open if this is still a problem.

Note: See TracTickets for help on using tickets.