Opened 9 years ago

Closed 7 years ago

#1766 closed enhancement (fixed)

Can't pass extra arguments to SVNPoller

Reported by: fgsch Owned by: bdbaddog
Priority: minor Milestone: 0.8.7
Version: 0.8.3p1 Keywords: svn, sprint
Cc:

Description

I want to use --no-auth-cache but there is no way to pass extra arguments. SVNPoller should implement extra_args as SVN does. F WIW, it probably would be better to unify all svn access code into one class and make SVNPoller and SVN use this, but this is a different story.

Change History (7)

comment:1 Changed 9 years ago by dustin

  • Keywords svn added
  • Milestone changed from undecided to 0.8.+

SVNPoller and SVN are in different projects (buildbot and buildbot-slave), so using the same code would be tricky. But yes, this is a good suggestion.

comment:2 Changed 9 years ago by fgsch

Unless I'm misunderstanding you, both are in buildbot:

buildbot/changes/svnpoller.py:class SVNPoller(base.ChangeSource, util.ComparableMixin?): buildbot/steps/source.py:class SVN(Source):

comment:3 Changed 9 years ago by dustin

True, but looking more closely, all of the "interesting" parts of the SVN step are implemented slave-side.

comment:4 Changed 7 years ago by dustin

  • Keywords sprint added

The latter isn't the case anymore, with master-side steps, so code-sharing is an option. Still, this shouldn't be particularly difficult.

comment:5 Changed 7 years ago by bdbaddog

  • Owner set to bdbaddog
  • Status changed from new to assigned

Work in progress. Code is done, working on tests, then I'll send a pull request.

comment:6 Changed 7 years ago by bdbaddog

Can you pull and try the code at: https://github.com/bdbaddog/buildbot/commit/fecd5bcb78fea91031bed27d216ab295cab5d1b8

And see if that resolves this issue for you?

I've set a pull request for this.

comment:7 Changed 7 years ago by tom.prince

  • Milestone changed from 0.8.+ to 0.8.7
  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.