Ticket #1753 (closed undecided: fixed)

Opened 2 years ago

Last modified 2 years ago

MailNotifier's __init__ has mode values hardcoded

Reported by: fgsch Owned by: ayust
Priority: minor Milestone: undecided
Version: 0.8.3 Keywords:
Cc:

Description

MailNotifier?'s init has mode values hardcoded in init so makes it difficult to implement new values without overriding init. It'd be better if the values are moved to class attributes or the assert removed entirely:

assert mode in ('all', 'failing', 'problem', 'change', 'passing')

Change History

comment:1 Changed 2 years ago by fgsch

  • Summary changed from MailNotifier's __init__ has mode values hardcoded in __init__ to MailNotifier's __init__ has mode values hardcoded

comment:2 Changed 2 years ago by Amber Yust

  • Status changed from new to closed
  • Resolution set to fixed

Move modes for MailNotifier? to a class variable.

Fixes #1753.

Changeset: 36c4e2f20fab6827b43cb7763b7734436ce5200c

Note: See TracTickets for help on using tickets.