Ticket #1740 (closed enhancement: fixed)
variable naming incorrect
|Reported by:||dreamfly912||Owned by:|
def mergeWith(self, others): """Generate a SourceStamp for the merger of me and all the other BuildRequests. This is called by a Build when it starts, to figure out what its sourceStamp should be.""" # either we're all building the same thing (changes==None), or we're # all building changes (which can be merged) changes =  changes.extend(self.changes) for req in others: changes.extend(req.changes) newsource = SourceStamp(branch=self.branch, revision=self.revision, patch=self.patch, project=self.project, repository=self.repository, changes=changes)
I think the variable 'req' used here in the for loop should mean 'sourcestamp'.
Should it be changed to a name that makes sense?
Note: See TracTickets for help on using tickets.