Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1732 closed enhancement (fixed)

Gerrit: add support for non-GerritChangeSource triggers

Reported by: PiotrSikora Owned by:
Priority: minor Milestone: 0.8.+
Version: 0.8.2 Keywords: gerrit, git, repovc
Cc:

Description

Both: Gerrit + Git and Gerrit + Repo need to support changes triggered by things other than GerritChangeSource? (like forced builds from the web interface).

We should support such format:

project branch change/patchset
buildbot master 1732/3

...and both VCs should retrieve proper revision and associate it with each patchset (in case of Repo), because we need revision for pushing code review back to Gerrit.

Change History (3)

comment:1 Changed 10 years ago by PiotrSikora

It seems that there are too many differences between how Git and Repo handle this to get away with one "universal" format.

Gerrit + Git needs project, branch and "virtual branch", so we could either require:

a) "gerrit_branch" or "event.patchSet.ref" property set to "refs/changes/61/61/2",

b) "gerrit_change" property set to "61/2" and calculate "event.patchSet.ref ourselves.

Gerrit + Repo needs (multiple) project, change and patchset id. Current implementation handles this with "d", "download", "download1", ..., "download9" properties and I think it's reasonable solution.

GerritStatusPush? is currently restricted to GerritChangeSource? because it requires "event.patchSet.ref" property, but it's easily fixable.

comment:2 Changed 10 years ago by Piotr Sikora

  • Resolution set to fixed
  • Status changed from new to closed

Catch-up with recent changes in Git and Repo, fixes #1731, #1732.

Changeset: 672bc6c63c0110af65a4ac8c71e936aed5a54c2f

comment:3 Changed 10 years ago by Dustin J. Mitchell

Merge branch 'master' of git://github.com/PiotrSikora/buildbot

  • 'master' of git://github.com/PiotrSikora/buildbot: Catch-up with recent changes in Git and Repo, fixes #1731, #1732. Add "repo_downloaded" property. Add support for "project/change_id/patchset_id" format. Clean-up in Repo code. Stop clobbering repo, when we've got bad change id. Remove "got_revision" generated by Repo - it's totally useless. Add support for fetching from "virtual branch" (take two). Revert "Add support for fetching from "virtual branch"." Changeset: 478dd986b9886a6fc7c49dbda33d4e3265a547bd
Note: See TracTickets for help on using tickets.