PBListener: inconsistent usernames between debug GUI and PBListener

[gward]

As shipped (0.7.6), buildbot.status.client.PBListener and the "debugclient" command (as implemented by buildbot.clients.debug.DebugWidget?) do not work together. The client prints

[Failure instance: Traceback from remote host -- Traceback unavailable
]

and the server logs

[2008-01-28 11:19:59] [Broker,12,127.0.0.1] Unhandled Error
        Traceback (most recent call last):
        Failure: twisted.cred.error.UnauthorizedLogin:

The problem is inconsistent authentication credentials: PBListener has a default username of "statusClient" and password "clientpw" (overrideable from config), while DebugWidget? is hardcoded to username "debug" and has a default password "debugpw" (overrideable from command line).

I got them to work together fairly easily after reading the code:

• in master.cfg, use PBListener(port=9990, user="debug", passwd="debug")
• run debugclient with "-p debug"

It's annoying that I had to dig through the code to get this to work. It's also pointless for PBlistener to take a 'user' parameter when the only username that will work is "debug".

Finally, buildbot/scripts/sample.cfg includes c['debugPassword'], which I suspect is either obsolete or misdocumented. (E.g. the comment refers to contrib/debugclient.py, which does not exist.)

[gward]

Oops. I now realize that I'm hooking up the wrong client and server: it appears that debugclient really wants to talk to an instance of buildbot.master.DebugPerspective?, not PBListener. Argh! How confusing! I think the real bug is that Buildbot appears to have two server objects for PB clients: PBListener and DebugPerspective?. DebugPerspective? certainly looks, umm, half-finished and experimental. So which is the one that should be used?

[dustin]

PBListener is for reporting new changes. DebugPerspective? is for the debugclient, but I don't think anyone's used that in years.