Opened 10 years ago

Closed 10 years ago

#1726 closed defect (fixed)

GerritStatusPush: unquoted message passed back to Gerrit

Reported by: PiotrSikora Owned by: PiotrSikora
Priority: critical Milestone: 0.8.4
Version: 0.8.2 Keywords: gerrit


At the moment GerritStatusPush? executes ssh without quoting comment message, which results in Gerrit parsing second word as the change id.

I'll take care of this.

Change History (1)

comment:1 Changed 10 years ago by Piotr Sikora

  • Resolution set to fixed
  • Status changed from new to closed

Quote message before passing it to Gerrit, fixes #1726.

While there, make this message optional and change "gerrit approve" to "gerrit review".

Changeset: 6aef2efa6782305c706b12d97e857b95e23cc3f0

Note: See TracTickets for help on using tickets.