Changes between Initial Version and Version 1 of Ticket #1725, comment 3


Ignore:


Timestamp:
Jul 27, 2011, 4:59:55 PM (8 years ago)
Author:
deignacio
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1725, comment 3

    initial v1  
    22i don't think you could use a ChangeFilter, because that has a bunch of code that is specific to changes, where as this is filtering BuildStatuses. 
    33in buildbot.status.builder whenever you do something like
     4
     5{{{
    46for w in self.watchers:
    57    try:
     
    1012        ....
    1113
    12 i think this would be super useful as you can have a configuration where not all builds are triggered by gerrit.  (think gerrit change source and github change notifications).
     14}}}
     15
     16i realize that this isn't super important since there is already a filter to only perform this for gerrit-based builds, but if perhaps you were doing builds on patchset-created but not ref-update, this would be helpful
    1317
    1418how's your progress on this?  i could probably put in some work into this if you wanted.