Opened 6 years ago

Last modified 3 years ago

#1725 new enhancement

GerritStatusPush: add filters on builderName, project, branch

Reported by: PiotrSikora Owned by: PiotrSikora
Priority: patches-accepted Milestone: 0.9.+
Version: 0.8.2 Keywords: gerrit
Cc:

Description (last modified by sa2ajj)

Currently GerritStatusPush? will try to push status update to Gerrit after build of every project in the system, perhaps it would be wise to add some filtering capabilities to it?

builderName and builderName_re should be enough, but maybe we should add filters for project and branch as well?

I'll take care of this, but I need some feedback on this feature.

Change History (7)

comment:1 Changed 6 years ago by dustin

Sounds good. Could it use a ChangeFilter?

comment:2 Changed 6 years ago by dustin

  • Milestone changed from 0.8.4 to 0.8.5

comment:3 Changed 6 years ago by deignacio

I could see this being useful for all StatusReceiver? subclasses. i don't think you could use a ChangeFilter?, because that has a bunch of code that is specific to changes, where as this is filtering BuildStatuses?. in buildbot.status.builder whenever you do something like

for w in self.watchers:
    try:
        if not w.filter(name, s, ...):
            continue
        w.someStep(name, s, ...)
    except:
        ....

i realize that this isn't super important since there is already a filter to only perform this for gerrit-based builds, but if perhaps you were doing builds on patchset-created but not ref-update, this would be helpful

how's your progress on this? i could probably put in some work into this if you wanted.

Last edited 6 years ago by deignacio (previous) (diff)

comment:4 Changed 6 years ago by PiotrSikora

Unfortunately, I'm a bit busy lately and I didn't touch Buildbot in months. Feel free to takeover this.

comment:5 Changed 4 years ago by tom.prince

  • Priority changed from major to patches-accepted

comment:6 Changed 3 years ago by dustin

  • Milestone changed from 0.8.+ to 0.9.+

Ticket retargeted after milestone closed

comment:7 Changed 3 years ago by sa2ajj

  • Description modified (diff)

MailNotifier? has a parameter builders that allows to limit the set of builders it sends notifications for. The other parameter (conflicting with builders) is categories (to use a different criterion).

IRC, on the other hand, has only categories.

I believe a more general agreement what should be the ways and make them available for all status targets.

Note: See TracTickets for help on using tickets.