Ticket #1712 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

hgbuildbot needs to learn sendchange authentication

Reported by: dustin Owned by:
Priority: major Milestone: 0.8.4
Version: 0.8.2 Keywords: hg
Cc: mark@…

Description

This should be a simple matter of adding some parameters to the class. Currently it uses the default auth ('change'/'changepw').

Change History

comment:1 Changed 2 years ago by mjw

  • Cc mark@… added

comment:2 follow-up: ↓ 3 Changed 2 years ago by dustin

mjw, is this something you can work on, or just an interest? We don't have a current Mercurial maintainer.

comment:3 in reply to: ↑ 2 Changed 2 years ago by mjw

Replying to dustin:

mjw, is this something you can work on

Yes, I'll try and make it work and attach a patch if I succeed. I am currently setting up a buildbot for the IcedTea? project which uses Mercurial for all source repositories.

comment:4 Changed 2 years ago by mjw

Testing the following patch:

  • buildbot/changes/hgbuildbot.py

    old new  
    7474        stripcount = int(ui.config('notify','strip') or ui.config('hgbuildbot','strip',3)) 
    7575        category = ui.config('hgbuildbot', 'category', None) 
    7676        project = ui.config('hgbuildbot', 'project', '') 
     77        auth = ui.config('hgbuildbot', 'auth', None) 
    7778    else: 
    7879        ui.write("* You must add a [hgbuildbot] section to .hg/hgrc in " 
    7980                 "order to use buildbot hook 
Last edited 2 years ago by dustin (previous) (diff)

comment:5 follow-up: ↓ 6 Changed 2 years ago by dustin

how is the patch working out?

comment:6 in reply to: ↑ 5 Changed 2 years ago by mjw

Replying to dustin:

how is the patch working out?

It works for me. I'll try and clean it up and add some documentation for a real patch submission.

comment:7 Changed 2 years ago by mjw

Created a patch plus some documentation.  https://github.com/buildbot/buildbot/pull/47

comment:8 Changed 2 years ago by mjw

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.