Opened 6 years ago

Closed 6 years ago

#1697 closed defect (fixed)

[twistd 10.2.0] LogFileScanner instance has no attribute '_remainingData'

Reported by: cunger Owned by:
Priority: blocker Milestone: 0.8.3
Version: 0.8.2 Keywords:
Cc:

Description (last modified by dustin)

Summary: After upgrading master and slaves to v0.8.2/ twisted 10.2.0 BuildStep?-logs do not seem to be accessible from the waterfall page. A custom buildStep for example class raises an exception in 'createSummary' (see below slave exception)

Steps to Reproduce: n/a

Expected Results: Logs should be accessible from the waterfall page.

Actual Results: Each request for a log from the waterfall page raises below excption in the master's log, and the http request times out.

Regression: Downgrading to twisted 8.2.0 solved the issue

Notes:

  • System Configuration:
  • Mac OS X Server 10.5, python 2.5, Twisted 10.2.0

master traceback:

[-] Unhandled Error
	Traceback (most recent call last):
	  File "/Library/Python/2.5/site-packages/Twisted-10.2.0-py2.5-macosx-10.5-i386.egg/twisted/application/app.py", line 311, in runReactorWithLogging
	    reactor.run()
	  File "/Library/Python/2.5/site-packages/Twisted-10.2.0-py2.5-macosx-10.5-i386.egg/twisted/internet/base.py", line 1158, in run
	    self.mainLoop()
	  File "/Library/Python/2.5/site-packages/Twisted-10.2.0-py2.5-macosx-10.5-i386.egg/twisted/internet/base.py", line 1167, in mainLoop
	    self.runUntilCurrent()
	  File "/Library/Python/2.5/site-packages/Twisted-10.2.0-py2.5-macosx-10.5-i386.egg/twisted/internet/base.py", line 789, in runUntilCurrent
	    call.func(*call.args, **call.kw)
	--- <exception caught here> ---
	  File "/Library/Python/2.5/site-packages/buildbot-0.8.2-py2.5.egg/buildbot/util/eventual.py", line 31, in _turn
	    cb(*args, **kwargs)
	  File "/Library/Python/2.5/site-packages/buildbot-0.8.2-py2.5.egg/buildbot/status/builder.py", line 180, in _resumeProducing
	    chunk = self.chunkGenerator.next()
	  File "/Library/Python/2.5/site-packages/buildbot-0.8.2-py2.5.egg/buildbot/status/builder.py", line 121, in getChunks
	    p.dataReceived(data)
	  File "/Library/Python/2.5/site-packages/Twisted-10.2.0-py2.5-macosx-10.5-i386.egg/twisted/protocols/basic.py", line 178, in dataReceived
	    self._remainingData += data
	exceptions.AttributeError: LogFileScanner instance has no attribute '_remainingData'

slave traceback:

1904:0Traceback (most recent call last):
  File "/Library/Python/2.5/site-packages/Twisted-10.2.0-py2.5-macosx-10.5-i386.egg/twisted/internet/defer.py", line 286, in addCallbacks
    self._runCallbacks()
  File "/Library/Python/2.5/site-packages/Twisted-10.2.0-py2.5-macosx-10.5-i386.egg/twisted/internet/defer.py", line 542, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/Library/Python/2.5/site-packages/Twisted-10.2.0-py2.5-macosx-10.5-i386.egg/twisted/internet/defer.py", line 361, in callback
    self._startRunCallbacks(result)
  File "/Library/Python/2.5/site-packages/Twisted-10.2.0-py2.5-macosx-10.5-i386.egg/twisted/internet/defer.py", line 455, in _startRunCallbacks
    self._runCallbacks()
--- <exception caught here> ---
  File "/Library/Python/2.5/site-packages/Twisted-10.2.0-py2.5-macosx-10.5-i386.egg/twisted/internet/defer.py", line 542, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/Library/Python/2.5/site-packages/buildbot-0.8.2-py2.5.egg/buildbot/process/buildstep.py", line 1064, in <lambda>
    d.addCallback(lambda res: self.createSummary(cmd.logs['stdio']))
  File "/Volumes/Untitled 2/old_hardRaid_20101126/buildbot/master/BuildSystem/xcodebuild.py", line 107, in createSummary
    logtext = log.getText()
  File "/Library/Python/2.5/site-packages/buildbot-0.8.2-py2.5.egg/buildbot/status/builder.py", line 321, in getText
    return "".join(self.getChunks([STDOUT, STDERR], onlyText=True))
  File "/Library/Python/2.5/site-packages/buildbot-0.8.2-py2.5.egg/buildbot/status/builder.py", line 372, in _generateChunks
    p.dataReceived(data)
  File "/Library/Python/2.5/site-packages/Twisted-10.2.0-py2.5-macosx-10.5-i386.egg/twisted/protocols/basic.py", line 178, in dataReceived
    self._remainingData += data
exceptions.AttributeError: LogFileScanner instance has no attribute '_remainingData'
,

Change History (2)

comment:1 Changed 6 years ago by dustin

  • Description modified (diff)
  • Milestone changed from undecided to 0.8.3
  • Priority changed from minor to blocker
  • Type changed from undecided to defect

comment:2 Changed 6 years ago by Dustin J. Mitchell

  • Resolution set to fixed
  • Status changed from new to closed

Use a NullTransport? to fake out NetstringReceiver?

Twisted-10.2.0 expects a real transport for a NetstringReceiver?, so give it something it can chew on. Fixes #1697

Changeset: c325859efc1d33644e0c7954e41af25cb95c1078

Note: See TracTickets for help on using tickets.