make public_html directory configurable

[dustin]

I'm not sure if I'm going to use this, but it seems like it will be generally useful. It adds a public_html= option to the WebStatus? constructor, allowing the user to configure the web directory to something other than a subdirectory of the basedir, if desired. I'm using this to serve html out of a subdirectory of our svn tree, but I can see that others might use it to serve several buildmasters out of the same HTML tree, for example.

[dustin]

public_html.patch

[dustin]

I need to add some documentation to this :)

[warner]

what about using a symlink? It isn't a bad feature, per se, but I'd like to avoid adding options that aren't really going to be used.

[dustin]

The symlink is awkward, because it has to be set up *after* the "create" operation is complete, and thus removes that aspect of the configuration from master.cfg.

I use lots of "local" installations of our buildbot config for various testing purposes, so this becomes important for my purposes. I don't think it adds a significant amount of additional complexity..

Added in my repo as #162:pubhtml.patch

[ijon]

This breaks my buildbot installation (on upgrade from 0.7.6+dustin-... to buildbot-0.7.7-dustin-20080701) -- because WebStatus now can't work without explicit specification of public_html parameter.

[ijon]

adds back default value of public_html

[dustin]

This works too:

diff -rN -u old-dustin/buildbot/status/web/baseweb.py new-dustin/buildbot/status/web/baseweb.py
--- old-dustin/buildbot/status/web/baseweb.py   2008-07-07 11:55:30.000000000 -0400
+++ new-dustin/buildbot/status/web/baseweb.py   2008-07-07 11:55:30.000000000 -0400
@@ -360,7 +360,7 @@
     # all the changes).
 
     def __init__(self, http_port=None, distrib_port=None, allowForce=False,
-                       public_html=None):
+                       public_html="public_html"):
         """Run a web server that provides Buildbot status.
 
         @type  http_port: int or L{twisted.application.strports} string

sorry about that!

This is in the devel repository, and I've built a new tarball.