No way to specify categories to waterfall child of WebStatus

[exarkun]

buildbot.status.web.waterfall.WaterfallStatusResource? takes a categories argument, like the old buildbot.status.web.Waterfall. buildbot.status.web.WebStatus? doesn't provide any way to pass a value for it to the waterfall it creates, though.

[Ukyo81]

This might have come a little late, but I had asked this question on the forums before. I think the following (updated) patch came out of the end of that discussion though, if this helps at all:

--- status/web/baseweb.py 2008-03-29 19:30:17.000000000 -0700 +++ status/web/baseweb.py 2008-03-31 16:42:36.000000000 -0700 @@ -350,7 +350,7 @@

# not (we'd have to do a recursive traversal of all children to discover # all the changes).

• def init(self, http_port=None, distrib_port=None, allowForce=False):

+ def init(self, http_port=None, distrib_port=None, categories=None, allowForce=False):

"""Run a web server that provides Buildbot status.

@type http_port: int or L{twisted.application.strports} string

@@ -398,6 +398,7 @@

distrib_port = "unix:%s" % distrib_port

self.distrib_port = distrib_port self.allowForce = allowForce

+ self.categories = categories

# this will be replaced once we've been attached to a parent (and # thus have a basedir and can reference BASEDIR/public_html/)

@@ -430,7 +431,7 @@

def setupUsualPages(self):

#self.putChild("", IndexOrWaterfallRedirection?())

• self.putChild("waterfall", WaterfallStatusResource?())

+ self.putChild("waterfall", WaterfallStatusResource?(self.categories))

self.putChild("builders", BuildersResource?()) # has builds/steps/logs self.putChild("changes", ChangesResource?()) self.putChild("buildslaves", BuildSlavesResource?())

[Ukyo81]

Fix for categories not working with WebStatus?

[Ukyo81]

Since the formatting got messed up in my first comment, I posted the patch that I used to take care of this problem in 0.7.7. Also, confirmed that this issue still occurs with 0.7.7.

[dustin]

The argument against this patch in 0.7.x is that the web pages are supposed to be "RESTful", which is to say that options are provided in the URL, not in the buildbot configuration. For 1.0, I think that things will be a lot more flexible.