"New-style" BuildFactory.addStep with ShellCommand disregards timeout keyword argument

[exarkun]

If a BuildFactory's __init__ does this:

    self.addStep(ShellCommand, timeout=60 * 60 * 2)

then the ShellCommand? will have a timeout of 2 hours. If it's done this way instead:

    self.addStep(ShellCommand(timeout=60 * 60 * 2))

then the timeout will be the default 20 minutes. The documentation suggests that the former is deprecated or pending deprecation, though.

[warner]

I just pushed a fix, [b060cf9b5d56366b6e505e81722004885f40cec6], that ought to fix this. It should also make sure that 'env' and 'workdir' are recorded too.

[warner]

I did some brief manual testing on this, looks like it works.